ADFA-5121: Remove dead UseSytemShell preference and unused setting - #1668
Merged
davidschachterADFA merged 4 commits intoAug 13, 2026
Merged
Conversation
UseSytemShell was never instantiated anywhere - no addPreference(UseSytemShell()) call exists in any screen builder, so it was unreachable from the Preferences UI. The setting it read/wrote (GeneralPreferences.useSystemShell / TERMINAL_USE_SYSTEM_SHELL) was likewise never consulted anywhere else in the codebase. Remove the class, the backing constant and property, and the title/summary strings across all 13 locale files (used only by this row). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
💤 Files with no reviewable changes (14)
📝 Walkthrough
WalkthroughThe system shell preference was removed from the preference declarations and storage contract. Its title and description were removed from localized resources. Remaining preference declarations were re-indented without behavior changes. ChangesSystem shell preference removal
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This change removes an unreachable preference and unused setting without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jatezzz
approved these changes
Aug 13, 2026
davidschachterADFA
deleted the
task/ADFA-5121-remove-dead-system-shell-pref
branch
August 13, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseSytemShell(a preference row for toggling/system/bin/shin the terminal) was never instantiated anywhere — noaddPreference(UseSytemShell())call exists in any screen builder, so it was unreachable from the Preferences UI. The setting it read/wrote (GeneralPreferences.useSystemShell/TERMINAL_USE_SYSTEM_SHELL) was likewise never consulted anywhere else in the codebase — a fully orphaned feature, found while auditing Preferences for ADFA-5088.UseSytemShellclass,TERMINAL_USE_SYSTEM_SHELLconstant, anduseSystemShellproperty.title_default_shell/msg_default_shellstrings from all 13 localestrings.xmlfiles (used only by this row). The sharedic_bash_commandsdrawable is left alone — it's also used byGradleCommands.Test plan
:app:compileV8DebugKotlin,:preferences:compileV8DebugKotlinsucceedspotlessCheckpasses🤖 Generated with Claude Code