Skip to content

plot_heatmaps / plot_heatmaps_logarithmic crash on their own default dimensions=None #24

Description

@ivankrylov

Both functions declare dimensions=None as the default (src/graphing/plotting.py:633
and :759), but get_heatmap_data immediately does len(dimensions)
(src/graphing/heatmap.py:207):
TypeError: object of type 'NoneType' has no len()
plot_heatmaps_logarithmic fails slightly differently: TypeError: '>' not supported
between instances of 'float' and 'NoneType'.

get_heatmap_data already has a friendly error path printing the expected dimensions
format when the list is the wrong length — None just never reaches it. Either guard
for None there, or make dimensions a required positional argument since there's no
usable default.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions