Simplify command execution and result ownership - #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command execution currently selects transaction modes separately for CSV and jq output, duplicating retry and committed-output handling. Prepare SQL, parameters, and jq once; execute the transaction through one path; and format either a live read-only iterator or completed results independently.
DML rows are buffered until commit for JSON, YAML, and CSV, and each retry replaces the previous result. CSV conversion now happens after commit, so conversion failures are reported as committed-output failures. Read-only CSV/lazy jq streaming and row-discard behavior are preserved. The CLI runner receives arguments and context, while the process entrypoint owns signals and exit handling; caller cancellation also reaches jq after SQL completes.
Validation: Go 1.25.13
go build ./...; fullgo test ./...including the Spanner emulator; golangci-lint v2.12.2 (0 issues). Regression coverage checks retries, commit failures, post-commit output failures across all three formats, DML RETURNING against the emulator, input preparation, and cancellation. Managed Spanner and Windows runtime behavior were not tested.