Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
UserNotFound
requested changes
Sep 2, 2026
UserNotFound
left a comment
Member
There was a problem hiding this comment.
Looks good, but we should bump the version to 1.0.2 so we can also release it.
Member
Author
See this 😉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion I started in Slack, this doesn't go quite as far as I would've hoped in updating things given that there's a few open questions about how to move forward.
This instead only -
aptible-taskswhich gets us one step closer to fully deprecating thatOverall, most of the changes are from
rubocop -a.There's one weirdo bit with spec/fixtures/app.rb where the correct thing to do is use Auth stubs correctly, but since it's a pretty minimal use case, I did the bare minimum instead.