This repository was archived by the owner on Mar 25, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Security: pin GitHub Actions to SHA hashes #11
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |
| - name: Check GitHub Issue type | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_type | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
| with: | ||
| result-encoding: string | ||
| script: | | ||
|
|
@@ -33,7 +33,7 @@ jobs: | |
| - name: Check if GitHub Issue has JIRA_ISSUE_LABEL | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' | ||
| id: github_issue_has_jira_issue_label | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
| env: | ||
| JIRA_ISSUE_LABEL: ${{ secrets.JIRA_ISSUE_LABEL }} | ||
| with: | ||
|
|
@@ -56,7 +56,7 @@ jobs: | |
| - name: Jira Login | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: login | ||
| uses: atlassian/gajira-login@v2.0.0 | ||
| uses: atlassian/gajira-login@90a599561baaf8c05b080645ed73db7391c246ed # v2.0.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 HIGH RISK The if condition on line 57 (and following steps) will never evaluate to true because it references env.GITHUB_ISSUE_TYPE, which is not available in the evaluation context. Step-scoped variables are not shared across steps. Try running the following prompt in your coding agent: > Fix the environment variable scoping in .github/workflows/comment_issue.yml by replacing env.VARIABLE_NAME in if conditions with steps.<step_id>.outputs.result or move the variables to the job-level environment. |
||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
@@ -67,7 +67,7 @@ jobs: | |
| - name: Extract Jira number | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: extract_jira_number | ||
| uses: actions/github-script@v2.0.0 | ||
| uses: actions/github-script@6e5ee1dc1cb3740e5e5e76ad668e3f526edbfe45 # v2.0.0 | ||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
@@ -82,7 +82,7 @@ jobs: | |
| - name: Jira Add comment on issue | ||
| if: env.JIRA_CREATE_COMMENT_AUTO == 'true' && env.GITHUB_ISSUE_TYPE == 'issue' && env.GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL == 'true' | ||
| id: add_comment_jira_issue | ||
| uses: atlassian/gajira-comment@v2.0.2 | ||
| uses: atlassian/gajira-comment@8ec356b5df49f1325653db7ee2da2b59a1d78203 # v2.0.2 | ||
| env: | ||
| GITHUB_ISSUE_TYPE: ${{ steps.github_issue_type.outputs.result }} | ||
| GITHUB_ISSUE_HAS_JIRA_ISSUE_LABEL: ${{ steps.github_issue_has_jira_issue_label.outputs.result }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 HIGH RISK
This script is vulnerable to script injection via direct expression interpolation. It is safer to pass dynamic data via environment variables. Also, consider upgrading to a supported version (v7) as v2 uses a deprecated Node.js 12 runtime that is being phased out. Try running the following prompt in your coding agent: > Refactor the github-script steps in .github/workflows/comment_issue.yml to pass all dynamic context data via environment variables using the env block and process.env, and upgrade the version to v7.