Change std::map to std::unordered_map in SSAValueTracker::m_values - #16921
Open
rodiazet wants to merge 2 commits into
Open
Change std::map to std::unordered_map in SSAValueTracker::m_values#16921rodiazet wants to merge 2 commits into
std::map to std::unordered_map in SSAValueTracker::m_values#16921rodiazet wants to merge 2 commits into
Conversation
clonker
reviewed
Aug 17, 2026
Member
There was a problem hiding this comment.
you may want to try the new boost-unordered-containers that sean recently pull-requested here
Contributor
Author
There was a problem hiding this comment.
pushed in a separated commit. I will prepare comparison soon.
Contributor
Author
There was a problem hiding this comment.
It took longer than expected. I had to run on 20 iterations and add MAD (Median Absolut Deviation) to filter out outliers. Results below.
rodiazet
force-pushed
the
unordered-map-ssa-value-tracker
branch
from
August 17, 2026 11:46
e19a35c to
63de7bd
Compare
Contributor
Author
|
clang gcc: |
Contributor
Author
|
clang: gcc: |
rodiazet
force-pushed
the
unordered-map-ssa-value-tracker
branch
from
August 21, 2026 12:54
8fdfc8d to
d3a76c3
Compare
rodiazet
marked this pull request as ready for review
August 21, 2026 12:54
Contributor
|
Do you want to write down some kind of summary? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR separates a change made initially in #16459. It’s unrelated change and should be benchmarked in separation.
Comment asking for separation https://github.com/argotorg/solidity/pull/16459/changes#r3766579197
AI Disclosure