Fix Piscis legacy model loading with converted checkpoint - #166
Merged
Conversation
arjunrajlab
marked this pull request as ready for review
August 7, 2026 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rajlab/ps_20240419_112256PyTorch checkpoint.ptfilename instead of downloading an extensionless legacy JAX checkpointdownload_models.pytestable while preserving the built-in Piscis model preloadThe converted checkpoint is published at https://huggingface.co/rajlab/ps_20240419_112256 and is the sole model in the Raj Lab Piscis collection.
Root cause
The legacy
ps_20240419_112256repository exposed an extensionless JAX checkpoint. Piscis therefore attempted an on-the-fly JAX-to-PyTorch conversion at worker runtime, which imports Flax. After the worker image was slimmed and Flax was removed, selecting that model failed withImportError: Flax is required for converting JAX models.Publishing and downloading a pre-converted
.ptcheckpoint keeps the inference image torch-only and avoids runtime conversion.Validation
.cache/testvenv/bin/python -m pytest workers/annotations/piscis/tests -q— 2 passedgit diff --checkf281a239d1d5075ee2342c4772ba7167c441f878e5345c632436caf3b43d320a