SUB-8652 feat(notifications): Vanta collaboration provider + config attributes - #696
chmod-777-shauli wants to merge 3 commits into
Conversation
…utes Adds CollaborationTypeVanta and the Vanta CollaborationConfig attribute keys (resourceIds per resource type, enabled flag, last-sync status) plus IsVantaEnabled, for the ARMO-Vanta integration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds first-class support for a new vanta collaboration provider by introducing provider identifiers and standardized attribute keys used to store Vanta integration state.
Changes:
- Introduces Vanta-specific
CollaborationConfig.Attributeskeys and a helper to check whether Vanta is enabled - Registers
vantaas a newChannelProvidertype
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| notifications/vanta.go | Adds Vanta attribute key constants and IsVantaEnabled helper |
| notifications/collaborationconfig.go | Adds CollaborationTypeVanta provider constant |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // VantaAttrUserAccountResourceID / VulnResourceID / PackageVulnResourceID | ||
| // hold the per-resource-type ids for the families ARMO syncs. | ||
| VantaAttrUserAccountResourceID = "vantaUserAccountResourceId" | ||
| VantaAttrVulnComponentResID = "vantaVulnerableComponentResourceId" | ||
| VantaAttrPackageVulnResID = "vantaPackageVulnerabilityResourceId" | ||
|
|
| VantaAttrEnabled = "vantaEnabled" | ||
| VantaAttrLastSyncAt = "vantaLastSyncAt" | ||
| VantaAttrLastSyncStatus = "vantaLastSyncStatus" // "ok" | "error" | ||
| VantaAttrLastSyncError = "vantaLastSyncError" | ||
| VantaAttrSyncedCount = "vantaSyncedCount" |
Coverage Report for CI Build 35242785443Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Warning No base build found for commit Coverage: 48.488%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
…nstants Addresses review: consistent ...ResourceID naming (stored string keys unchanged) and VantaSyncStatusOK/Error constants instead of magic strings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed as part of the 5-PR Vanta set. The code here is clean. 27 additive lines, constants plus one helper, nothing to fix. One observation: Process itemNo PR in this set links a Jira ticket or a PRD, and none marks itself Related: armosec/armosec-infra#599 has code comments referring to risks "R2" and "R3". I could not find a Vanta design doc in Actions for you
No code changes requested on this PR. It is correctly first in the merge order. |
Jira: SUB-8652
Part of the ARMO→Vanta integration (base library, merge first).
Adds
CollaborationTypeVanta, the VantaCollaborationConfigattribute keys (per-family resourceIds, enabled flag, last-sync status), andIsVantaEnabled.Merge order
🤖 Generated with Claude Code
AI-skills: superpowers:brainstorming,armosec-shared-rules:docs_find,superpowers:writing-plans,superpowers:test-driven-development,artifact-design,armosec-shared-rules:multi-repo-feature-workflow