Skip to content

SUB-8652 feat(notifications): Vanta collaboration provider + config attributes - #696

Open
chmod-777-shauli wants to merge 3 commits into
mainfrom
feature/vanta-integration
Open

chmod-777-shauli wants to merge 3 commits into
mainfrom
feature/vanta-integration

Conversation

@chmod-777-shauli

@chmod-777-shauli chmod-777-shauli commented Aug 18, 2026

Copy link
Copy Markdown

Jira: SUB-8652

Part of the ARMO→Vanta integration (base library, merge first).

Adds CollaborationTypeVanta, the Vanta CollaborationConfig attribute keys (per-family resourceIds, enabled flag, last-sync status), and IsVantaEnabled.

Merge order

  1. this (armoapi-go — no deps)
  2. armosec-infra, authentication-service
  3. cadashboardbe, event-ingester-service (bump to these)

🤖 Generated with Claude Code

AI-skills: superpowers:brainstorming,armosec-shared-rules:docs_find,superpowers:writing-plans,superpowers:test-driven-development,artifact-design,armosec-shared-rules:multi-repo-feature-workflow

…utes

Adds CollaborationTypeVanta and the Vanta CollaborationConfig attribute keys
(resourceIds per resource type, enabled flag, last-sync status) plus
IsVantaEnabled, for the ARMO-Vanta integration.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 15:14
@chmod-777-shauli chmod-777-shauli added the ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin) label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 314fd3f6-3b55-455f-befd-4381b3b464ca


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds first-class support for a new vanta collaboration provider by introducing provider identifiers and standardized attribute keys used to store Vanta integration state.

Changes:

  • Introduces Vanta-specific CollaborationConfig.Attributes keys and a helper to check whether Vanta is enabled
  • Registers vanta as a new ChannelProvider type

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
notifications/vanta.go Adds Vanta attribute key constants and IsVantaEnabled helper
notifications/collaborationconfig.go Adds CollaborationTypeVanta provider constant

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread notifications/vanta.go
Comment on lines +9 to +14
// VantaAttrUserAccountResourceID / VulnResourceID / PackageVulnResourceID
// hold the per-resource-type ids for the families ARMO syncs.
VantaAttrUserAccountResourceID = "vantaUserAccountResourceId"
VantaAttrVulnComponentResID = "vantaVulnerableComponentResourceId"
VantaAttrPackageVulnResID = "vantaPackageVulnerabilityResourceId"

Comment thread notifications/vanta.go
Comment on lines +15 to +19
VantaAttrEnabled = "vantaEnabled"
VantaAttrLastSyncAt = "vantaLastSyncAt"
VantaAttrLastSyncStatus = "vantaLastSyncStatus" // "ok" | "error"
VantaAttrLastSyncError = "vantaLastSyncError"
VantaAttrSyncedCount = "vantaSyncedCount"
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 35242785443

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Warning

No base build found for commit 8239d92 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 48.488%

Details

  • Patch coverage: 4 uncovered changes across 1 file (0 of 4 lines covered, 0.0%).

Uncovered Changes

File Changed Covered %
notifications/vanta.go 4 0 0.0%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 5193
Covered Lines: 2518
Line Coverage: 48.49%
Coverage Strength: 6.01 hits per line

💛 - Coveralls

Shauli Rozen and others added 2 commits August 18, 2026 18:29
…nstants

Addresses review: consistent ...ResourceID naming (stored string keys unchanged)
and VantaSyncStatusOK/Error constants instead of magic strings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@rotemamsa

Copy link
Copy Markdown

Reviewed as part of the 5-PR Vanta set.

The code here is clean. 27 additive lines, constants plus one helper, nothing to fix.

One observation: IsVantaEnabled is added here but the cron that enumerates Vanta customers (armosec/event-ingester-service#2160) filters on provider only and never calls it. So a disabled or half-configured connection gets triggered nightly and counted as a failure. Worth wiring this helper into that filter, which is presumably why it exists.

Process item

No PR in this set links a Jira ticket or a PRD, and none marks itself Source of Truth: N/A. On this PR the change is small enough that I would call that a nit rather than a blocker. It is a blocker on the other four, so one ticket linked from all five clears it everywhere.

Related: armosec/armosec-infra#599 has code comments referring to risks "R2" and "R3". I could not find a Vanta design doc in specs/, plans/ or shared-designs-and-docs/. If that risk register exists, please link it. Without it there is no way to check whether R1 and R4 were also closed.

Actions for you

  1. Link the Jira ticket or design doc in the PR body.
  2. Confirm whether IsVantaEnabled should gate the event-ingester cron, and file it if so.

No code changes requested on this PR. It is correctly first in the merge order.

@chmod-777-shauli chmod-777-shauli changed the title feat(notifications): Vanta collaboration provider + config attributes SUB-8652 feat(notifications): Vanta collaboration provider + config attributes Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Created through Armosec AI tooling (armosec-shared-rules plugin)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants