Add ESP32-S3 companion support and harden Command Centre config/file handling

[Copilot]

This change adds the ESP32-S3 companion scaffold and wires the Command Centre to manage shared firmware, RGB profiles, and related storage paths. It also removes unintended config writes and tightens managed-path handling so the new flows behave predictably.

• Command Centre surface area

  • Adds API/UI support for provider selection, shared storage, secondary firmware staging, and RGB profile selection.
  • Exposes a firmware catalog spanning shared assets, staged secondary assets, and the local ESP32-S3 project.

• Config and provider behavior

  • Normalizes shared_dir and secondary_firmware_dir consistently under managed roots.
  • Removes save-on-read behavior from HTTP handlers and server startup.
  • Canonicalizes the legacy gemini alias to the google provider to avoid duplicate registry entries in the UI.

• Filesystem safety

  • Resolves firmware actions through managed asset catalogs instead of trusting arbitrary request paths.
  • Revalidates source/destination paths against configured roots before copy/create operations.

• ESP32-S3 companion scaffold

  • Adds the native ESP-IDF scaffold, partition layout, RGB profile definitions, and host-simulation path.
  • Keeps GPIO reporting consistent by deriving status output from the shared GPIO constant.

• Regression coverage

  • Adds tests for shared/secondary directory normalization.
  • Adds tests that verify Command Centre reads and firmware actions do not persist config unexpectedly.

func (c *Config) Set(key, value string) {
	switch key {
	case "provider":
		info := provider.LookupProvider(value)
		if info != nil {
			c.Provider = info.ID // canonicalizes "gemini" -> "google"
			c.BaseURL = info.BaseURL
		} else {
			c.Provider = value
		}
	}
	c.normalize()
}

[Copilot]

🟡 Changes recommended

The Command Centre currently exposes sensitive config fields to the browser and has a couple of concrete correctness/security issues (XSS risk, stale /shared root, and path-prefix logic).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds an ESP32-S3 companion scaffold and introduces a new “Command Centre” surface in the Android daemon to manage providers, shared storage, firmware staging, and RGB profiles, alongside config normalization and regression tests to prevent unintended persistence.

Changes:

• Added esp32_s3/ companion scaffold (ESP-IDF project files, partition layout, Lua RGB profiles, host simulation).
• Added Command Centre UI/API endpoints plus firmware catalog + install/flash actions, and exposed /shared/ browsing.
• Hardened config/provider behavior (directory normalization, provider alias canonicalization) and added regression tests.

File summaries

File	Description
README.md	Documents ESP32-S3 companion and Command Centre component; updates provider list.
esp32_s3/README.md	New documentation for ESP32-S3 scaffold, layout, and host simulation.
esp32_s3/partitions.csv	Defines partitions including spore_assets for staged firmware/assets.
esp32_s3/main/spore_esp32_s3.c	New companion firmware + host sim, Lua-backed RGB profile loading, status snapshot scaffold.
esp32_s3/main/rgb_profiles.lua	Default RGB activity profiles/patterns.
esp32_s3/main/CMakeLists.txt	ESP-IDF component registration for companion firmware.
esp32_s3/CMakeLists.txt	ESP-IDF project scaffold entry.
android/README.md	Mentions Command Centre and adds provider setup examples.
android/provider/provider.go	Expands/adjusts provider registry; canonicalizes gemini → google.
android/main.go	Updates CLI help to include Command Centre and expanded providers.
android/go.mod	Marks nhooyr.io/websocket as a direct dependency.
android/daemon/webchat.go	Adds a navigation link to /command-centre.
android/daemon/daemon.go	Registers Command Centre routes and /shared/ file browsing.
android/daemon/command_centre.go	New Command Centre API/UI, firmware catalog + install/flash actions, storage/provider controls.
android/daemon/command_centre_test.go	New tests for Command Centre behavior and persistence expectations.
android/core/config.go	Adds shared/storage fields and normalizes managed directories; provider canonicalization.
android/core/config_test.go	Adds tests for shared/secondary dir normalization and provider alias canonicalization.

Review details

• Files reviewed: 17/17 changed files
• Comments generated: 8
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.