fix(installer): use clean lifecycle binary name - #337
Draft
sandersonstabo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Converges every versioned installer lifecycle check on the approved clean executable leaf:
versions/<version>/bin/installer.exeon Windows andinstallerelsewhere.The stable launcher remains
ae.exe; the internal Cargo package remainsae-installer.Verification
//modules/installer:installerand unit-test targets build//:format_testpassesReceipt:
D:/artisan-editor-gate-logs/portable-installer-lifecycle-name-20260829-gate1/receipt.jsonNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Renames the versioned installer lifecycle binary from
ae-installertoinstaller(installer.exeon Windows), so every lifecycle check uses the same clean name.versioned_installer_pathhelper for the platform-specific path used in install, repair, and tests.bin/installer(bin/installer.exeon Windows); theMissingInstallererror text is updated to match.Written for commit 1139de8. Summary will update on new commits.