Make the iOS ADE scheme build again - #1123
Conversation
The iOS app is not built by PR CI, and three recent merges each landed a compile break that the next one hid: - WorkSessionDestinationView passed onOpenParentSession right after onOpenLane, but memberwise-init argument order follows property declaration order in WorkChatSessionView, where it sits after the model controls (#1117). - SyncService.errorByClearingAmbiguousRouteAuthFailure is called from the connection race's task-group closures off the main actor; it is a pure NSError rewrite, so mark it nonisolated (#1120). - WorkChatSessionView.body had grown into one ~300-line expression chain; the x86_64 simulator slice hit the type-checker's "unable to type-check in reasonable time" ceiling (#1121). Split it into bounded helpers (transcriptScrollView / chatColumn / timelineScrollHandlers / sessionLifecycleHandlers / feedbackAndSheets) with the identical view tree and modifier order. Verified: xcodebuild build-for-testing succeeds for the ADE scheme (simulator, both arches); ADETests runs 1494 tests with 6 failures that predate this branch (PR-list workflow context, roster delta, sync recovery policy — tracked separately). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reached
Next review available in: 39 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
PR CI does not build iOS, and three recent merges each landed a compile break that the next one hid. This restores a green
xcodebuild build-for-testingfor the ADE scheme:WorkSessionDestinationView):onOpenParentSession:moved to its memberwise-init position (after the model controls) — broken since Mobile Session Card Fixes -> main #1117.SyncService):errorByClearingAmbiguousRouteAuthFailureis a pure NSError rewrite called from task-group closures off the main actor; nownonisolated— broken since Stop unknown-device sync rejection storms and Windows EBUSY flakes #1120.WorkChatSessionView):bodyhad grown into one ~300-line expression; the x86_64 simulator slice hit the "unable to type-check in reasonable time" ceiling after Cursor SDK Chat Recovery -> main #1121. Split into bounded helpers with the identical view tree and modifier order.Verified locally: build-for-testing succeeds (both arches);
ADETestsruns 1494 tests — 6 failures all predate this branch (PR-list workflow context from the PRs-tab parity PR, roster delta, sync recovery policy) and are reported separately. The Cursor dispatch-capability tests from #1121 pass.🤖 Generated with Claude Code