mobile-connection-badges-layout -> Primary - #974
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe iOS connection UI removes explanatory section hints, simplifies connection-pill content, stacks connection status details vertically, adds context-menu renaming for machine rows, and prevents reconnecting to the already-current entry. ChangesiOS connection UI
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/ios/ADE/Views/Hub/HubComponents.swift (1)
157-167: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winRemove the stale
transportLabelreference.
transportLabelwas removed fromHubConnectionPill, but Line 167 still uses it to calculate padding. This is a compile error. Replace it with fixed single-line padding or restore a valid property if dynamic padding is still required.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/ios/ADE/Views/Hub/HubComponents.swift` around lines 157 - 167, Remove the stale transportLabel reference from HubConnectionPill’s vertical padding calculation. Replace the conditional padding with fixed single-line padding, or use an existing valid property only if dynamic padding remains required, ensuring the view compiles.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/ios/ADE/Views/Settings/ConnectionSettingsView.swift`:
- Around line 885-911: Update the connection row Button around MachineRowView so
its enabled state matches tappable, preventing activation when the entry is
current or another connection is in progress. Preserve the existing visual
opacity and ensure the rename context menu remains available for non-connectable
rows.
---
Outside diff comments:
In `@apps/ios/ADE/Views/Hub/HubComponents.swift`:
- Around line 157-167: Remove the stale transportLabel reference from
HubConnectionPill’s vertical padding calculation. Replace the conditional
padding with fixed single-line padding, or use an existing valid property only
if dynamic padding remains required, ensuring the view compiles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a11d53a5-4289-40e7-baf4-4207bae72f8a
📒 Files selected for processing (4)
apps/ios/ADE/Views/Account/AccountConnectionsSection.swiftapps/ios/ADE/Views/Hub/HubComponents.swiftapps/ios/ADE/Views/Settings/ConnectionSettingsView.swiftapps/ios/ADE/Views/Settings/SettingsConnectionHeader.swift
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf72d13a57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SettingsNavigationRow( | ||
| title: "Connection details", | ||
| subtitle: "Route and connection performance", | ||
| systemImage: "point.3.connected.trianglepath.dotted" |
There was a problem hiding this comment.
On a fresh install or before the first successful connection, both connectionRoute and connectionPerformance are nil, but this navigation row remains visible. Opening it produces an entirely empty page because .connection suppresses the About section and the connection section renders only when either value exists; hide or disable the row, or provide a concrete empty state.
AGENTS.md reference: AGENTS.md:L59-L60
Useful? React with 👍 / 👎.
| ) { | ||
| presentedSheet = .scan | ||
| } | ||
| DisclosureGroup(isExpanded: $showsAddMachine) { |
There was a problem hiding this comment.
In the no-account onboarding path, MobileAccessGateView presents ConnectionSettingsView(pairingOnly: true) specifically so the user can pair a Mac. Since showsAddMachine defaults to false and the scanner and discovery actions were moved into this disclosure, that sheet now hides every pairing action behind an extra tap; keep the disclosure expanded for the pairing-only context or pass an initial expansion state.
AGENTS.md reference: AGENTS.md:L60-L60
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary by CodeRabbit