fix(create-pds): export Space Durable Objects from template worker - #248
Open
ascorbic wants to merge 1 commit into
Open
fix(create-pds): export Space Durable Objects from template worker#248ascorbic wants to merge 1 commit into
ascorbic wants to merge 1 commit into
Conversation
The scaffolded wrangler.jsonc declares SpaceDurableObject and SpaceIndexDurableObject bindings and migrations, but the worker entry only re-exported AccountDurableObject. Wrangler rejects the deploy with error 10070 because the migration names a class the script does not export. The template entry now matches demos/pds. Closes #246
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
pdscheck | 5ce359c | Sep 12 2026, 05:11 PM |
commit: |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cirrusdocs | 5ce359c | Commit Preview URL Branch Preview URL |
Sep 12 2026, 05:12 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrangler.jsonchas declaredSpaceDurableObjectandSpaceIndexDurableObjectbindings and migrations since feat(pds): mount atproto spaces behind SPACES_ENABLED #212, but the template worker entry only re-exportedAccountDurableObject. Wrangler rejects every fresh deploy with error 10070 (Cannot apply new-class migration to class 'SpaceDurableObject' that is not exported by script).src/index.tsnow re-exports all three Durable Object classes, matchingdemos/pds/src/index.ts.create-pdspatch changeset.Closes #246
Test plan
pnpm testinpackages/create-pdspasses (scaffold e2e).create-pdsand runwrangler deploy(or--dry-run); the 10070 migration error no longer occurs.The reporter's follow-ups (making Spaces opt-in while alpha, and a deploy dry run in CI so this drift is caught automatically) are out of scope here and will be handled separately.