Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions apps/web/src/components/chat/MessagesTimeline.logic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
resolveAssistantMessageCopyState,
resolveTimelineMinimapWheelIndex,
shouldPreserveAssistantLineBreaks,
timelineMinimapWheelTargetsHitStrip,
} from "./MessagesTimeline.logic";

describe("resolveTimelineMinimapWheelIndex", () => {
Expand Down Expand Up @@ -34,6 +35,28 @@ describe("resolveTimelineMinimapWheelIndex", () => {
});
});

describe("timelineMinimapWheelTargetsHitStrip", () => {
it("accepts wheel events over the minimap bars", () => {
expect(
timelineMinimapWheelTargetsHitStrip({
pointerX: 24,
hitStripLeft: 12,
hitStripWidth: 40,
}),
).toBe(true);
});

it("rejects wheel events over the expanded preview", () => {
expect(
timelineMinimapWheelTargetsHitStrip({
pointerX: 100,
hitStripLeft: 12,
hitStripWidth: 40,
}),
).toBe(false);
});
});

describe("shouldPreserveAssistantLineBreaks", () => {
it("preserves Claude insight formatting without changing regular markdown", () => {
expect(
Expand Down
20 changes: 20 additions & 0 deletions apps/web/src/components/chat/MessagesTimeline.logic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,26 @@ export function resolveTimelineMinimapWheelIndex(input: {
return Math.max(0, Math.min(input.itemCount - 1, currentIndex + direction));
}

export function timelineMinimapWheelTargetsHitStrip(input: {
readonly pointerX: number;
readonly hitStripLeft: number;
readonly hitStripWidth: number;
}): boolean {
if (
!Number.isFinite(input.pointerX) ||
!Number.isFinite(input.hitStripLeft) ||
!Number.isFinite(input.hitStripWidth) ||
input.hitStripWidth <= 0
) {
return false;
}

return (
input.pointerX >= input.hitStripLeft &&
input.pointerX <= input.hitStripLeft + input.hitStripWidth
);
}

export function resolveTimelineMinimapHasPersistentGutter(viewportWidth: number): boolean {
if (!Number.isFinite(viewportWidth) || viewportWidth <= 0) {
return false;
Expand Down
13 changes: 12 additions & 1 deletion apps/web/src/components/chat/MessagesTimeline.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ import {
resolveTimelineMinimapTopPercent,
resolveTimelineMinimapWheelIndex,
shouldPreserveAssistantLineBreaks,
timelineMinimapWheelTargetsHitStrip,
type StableMessagesTimelineRowsState,
type MessagesTimelineRow,
TIMELINE_MINIMAP_MIN_ITEMS,
Expand Down Expand Up @@ -787,6 +788,16 @@ function TimelineMinimap({
}

const rect = button.getBoundingClientRect();
if (
!timelineMinimapWheelTargetsHitStrip({
pointerX: event.clientX,
hitStripLeft: rect.left,
hitStripWidth,
})
) {
return;
}

const pointerIndex = resolveTimelineMinimapIndexFromPointer({
itemCount: items.length,
railTop: rect.top,
Expand Down Expand Up @@ -815,7 +826,7 @@ function TimelineMinimap({
wheelIndexRef.current = nextIndex;
onSelect(nextItem);
},
[items, onSelect],
[hitStripWidth, items, onSelect],
);

useEffect(() => {
Expand Down
Loading