Document builder query endpoints (userAccounts/userOpenOrders/userBal… - #166
Open
ivanzyzy wants to merge 3 commits into
Open
Document builder query endpoints (userAccounts/userOpenOrders/userBal…#166ivanzyzy wants to merge 3 commits into
ivanzyzy wants to merge 3 commits into
Conversation
…ances/userPositionRisk/userCommissionRates/userAllOrders) and all-asset-logo Adds the builder-family GET endpoints from builder.txt that were missing from the futures v3 docs, and fixes the existing Get Builder Trades doc to match source (missing userAddresses param, 90-day not 30-day startTime window, errors[] field). userAddresses is capped at 50 per request. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Enumerates the four concrete error messages (deposit required, privacy mode enabled, privacy check failed, not bound to builder) that can appear per-address in the errors[] array, confirmed against AccountService.getAccountIdsByAddresses/getFutureUidsByAddresses and a real response sample. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ition filter Per PR #166 QA review: fee is negated relative to the DB (verified in cloud-future-campaign's UserTradeController) and not trailing-zero-trimmed like other decimal fields, so the doc's example and field description were wrong. Also documents that the batch userPositionRisk endpoint drops positionAmt=0 rows server-side (cloud-query-service DataRiskServiceImpl.getPositionRiskBatch), unlike the single-account positionRisk endpoint. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ances/userPositionRisk/userCommissionRates/userAllOrders) and all-asset-logo
Adds the builder-family GET endpoints from builder.txt that were missing from the futures v3 docs, and fixes the existing Get Builder Trades doc to match source (missing userAddresses param, 90-day not 30-day startTime window, errors[] field). userAddresses is capped at 50 per request.