TypeId in Verus to support Any - #720
Open
SNoAnd wants to merge 5 commits into
Open
Conversation
Collaborator
|
There seems to be a dependency issue. |
Collaborator
Author
|
Yes, the patch was outdated. I've updated it. |
Collaborator
|
@SNoAnd Maybe you can create a new branch in |
Collaborator
|
BTW, can we try to create a PR to get feedback from the Verus team? This is a big change and I'm not very confident. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR won't run on stock Verus. In order to run it, first apply
patches/0001-verus-type-identity.patchto the Verus tree. That patch adds aTypeIdSpectype to Verus, such that each registered type in the program receives a unique ID. We then consume that ID in theAnytrait, which exposes it as an exec object. The payoff can be seen inFrame<dyn AnyFrameMeta>::try_from, which casts the meta up to anAnyand then checks its type ID and casts it down to the target type if correct.One remaining gap in this setup is the up-cast. In Rust it is allowed as a normal cast, because
AnyFrameMeta: Any. Verus forbids using user-defined traits as supertraits of traits that will havedynusage. The current approach is to put the equivalent method inAnyFrameMeta.