Cover submit+poll via sensor pattern in airflow-state-store skill - #251
Merged
Conversation
kaxil
force-pushed
the
task-store-skill-update
branch
from
August 3, 2026 13:29
1301068 to
07aee60
Compare
kaxil
reviewed
Aug 3, 2026
amoghrajesh
force-pushed
the
task-store-skill-update
branch
from
August 4, 2026 08:59
07aee60 to
86c14c6
Compare
Contributor
Author
|
@kaxil can you take another look when possible please? |
kaxil
enabled auto-merge (squash)
August 5, 2026 07:10
kaxil
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://lists.apache.org/thread/xhlwpy4mpptw842dfv0dqyxwkzxq3936
Per community discussion on submit+poll patterns, recommend Airflow's built-in durable execution mode instead of a hand-rolled submit task + sensor/poll task split, for cases where a Triggerer isn't deployed but the job can run synchronously. Adds a Triggerer- and job-duration- conditioned decision tree to the airflow-state-store skill, fixes the skill's proactive trigger so it actually fires when reviewing this DAG shape, and clarifies that ResumableJobMixin's crash-safety only applies
to a single-task submit+poll, not an already-split submit/sensor pair and recommends it as needed.
Net result now:
Testing
Before my skill update:
before.md
After my skill update
after.md