Skip to content

Hoist None/tuple axis handling into _nanfuncs._setup #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwcraig merged 3 commits into from
Aug 31, 2026
Merged

Hoist None/tuple axis handling into _nanfuncs._setup #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
850a4d6
Hoist None/tuple axis handling into _nanfuncs._setup
mwcraig Aug 31, 2026
c801431
Address review on #1006: fix two _setup edge cases, simplify, document
mwcraig Aug 31, 2026
9d18599
Template the repeated x/axis/xp docstring entries in _nanfuncs
mwcraig Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,13 @@ New Features
classified differently from astropy (NumPy data still use astropy);
``'median'``/``'mean'``/``'std'``/``'mad_std'`` use the namespace's
NaN-aware reductions or ccdproc's fallbacks. [#1001]
- ``Combiner.sigma_clipping`` outside NumPy now accepts ``axis=None`` and a
tuple or list of axes, as ``astropy.stats.sigma_clip`` does on the NumPy
path, and the reduction fallbacks in ``ccdproc._nanfuncs`` gained the same
axis forms; the None/tuple axis handling formerly in ``_mad_fallback``
moved into the shared ``_nanfuncs._setup``, and a bool or otherwise
non-integer ``axis`` now raises ``TypeError`` rather than
``NotImplementedError``. [#1006]

Other Changes and Additions
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
Loading