Skip to content

docs: correct PDF hook comment typos #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seung983150-hash wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

docs: correct PDF hook comment typos #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hooks/99_generatePdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ const puppeteer = require('puppeteer');
const path = require('path');

/**
* Generates PDF if user pass `pdf` paramater.
* Generates a PDF if the user passes the `pdf` parameter.
*/
module.exports = {
'generate:after': async ({ templateParams = {}, targetDir }) => {
// all actions of this hook depend on parameters passed by the user,
// if non are provided we should just stop the hook
// if none are provided we should just stop the hook
if (templateParams.pdf !== 'true') {
return;
}
Expand All @@ -24,7 +24,7 @@ module.exports = {
// Hide burger-menu in pdf
await page.evaluate(() => { document.querySelector('.burger-menu').style.display = 'none'; });

// React uses its own events system with SyntheticEvents (prevents browser incompatabilities and gives React more control of events),
// React uses its own events system with SyntheticEvents (prevents browser incompatibilities and gives React more control of events),
// so we must use `{ bubbles: true }`
await page.$$eval('button > svg', chevrons => chevrons.forEach(chevron => {
const button = chevron.parentElement;
Expand Down
Loading