fixed bug in dataset tests - #791
Open
jnsLs wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates local-only dataset tests to match the post-#781 dataset/datamodule API (construct dataset instances directly, then wrap them in AtomsDataModule and run setup()), while isolating split artifacts in a temporary working directory.
Changes:
- Refactor QM9/MD17/rMD17 tests to use
AtomsDataModule(dataset, ...)instead of passing dataset-specific args into dataset constructors/datamodules inconsistently. - Write split files into
tmp_pathand callsetup()to populate train/val/test subsets and dataloaders.
Suppressed comments (1)
tests/data/test_datasets.py:55
- Same CWD/path interaction as in
test_qm9: changing the working directory before resolvingtest_md17_pathcan make a relative path point to the wrong location. Resolve the DB path to absolute beforechdir()and pass that toMD17.
def test_md17(test_md17_path, tmp_path, monkeypatch):
monkeypatch.chdir(tmp_path)
dataset = MD17(test_md17_path, molecule="uracil")
md17 = AtomsDataModule(
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #781 broke the dataset tests. this PR fixes the latent bug