fix(x/dynamicfee): enforce params.Window == len(state.Window) in genesis validation - #113
Open
giunatale wants to merge 3 commits into
Open
fix(x/dynamicfee): enforce params.Window == len(state.Window) in genesis validation#113giunatale wants to merge 3 commits into
giunatale wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
params.Window == len(state.Window)invariant was enforced only as a panic inkeeper.InitGenesis, never inValidateBasic. So a mismatched genesis (e.g.window: "4"with the default 8-slotstate.window) passesatomoned genesis validateand then panics every node inInitChainbefore block 1.Enforce the invariants where
genesis validatesees them:State.ValidateBasic: reject emptyWindow(len == 0, not justnil) andIndex >= len(Window).GenesisState.ValidateBasic: rejectparams.Window != len(state.Window).InitGenesis: drop the now-redundant window panic (gs.ValidateBasic()covers it).