fix(photon): prevent bundling the wildcard symbol in TxFeeExceptions with other exceptions - #352
Merged
Merged
Conversation
Collaborator
Author
|
BTW, if we want a CL entry for this, I'll need to go ahead and add a new section above v4. LMK |
tbruyelle
approved these changes
Jun 25, 2026
tbruyelle
left a comment
tbruyelle
left a comment
Collaborator
There was a problem hiding this comment.
Yes let's add a new section for the CL.
Collaborator
Author
|
Ok done @tbruyelle if it looks good I'll merge. It should be ok, but asking for confirmation just in case |
Collaborator
|
yeah it's good go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the wildcard symbol
*bundled with other messages is semantically wrong and should be prevented. The wildcard should exist by itself, and up until this PR an ill-formatted assignment forTxFeeExceptionsof the kind[MsgFoo, *]would silently be accepted and result in the wildcard being ignored, since the code expects it to be the first (and essentially only) entry in the list.Note: this is a nitpick fix, it is not required for v4 and can be treated independently and scheduled to be deployed in a future update. There's no urgency nor any cause of concern. This PR is just for code correctness, and impact is marginal at best (also because we don't expect the
TxFeeExceptionsparam to be updated any time soon)