Fix for vite-5, CDK bootstrap and Amplify Service role - #7
Merged
Conversation
Run `npm ci` (the same command Amplify's build and `ampx pipeline-deploy` use) plus the SPA build on every push/PR touching webapp/**, so package.json/package-lock.json drift is caught before it reaches an Amplify deploy. This is the drift that previously broke the backend build at its first command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Final state
Fork main (0b10392) — has both the vite‑5 lockfile fix and the webapp-ci.yml guard. Confirmed the workflow is live on main (HTTP 200). The earlier deploy (job #7) already succeeded and the app returns HTTP 200; this push adds the guard.
Fork branch fix/webapp-lockfile-sync — pushed, containing the same lockfile fix + CI workflow off aws-samples/main, ready to become the upstream PR.
Your one remaining click
I can't call the GitHub API from here (no token/gh), so you open the PR and issue:
PR (base aws-samples/main ← your branch): https://github.com/aws-samples/sample-devops-agent-orchestrator/compare/main...aamahajan:testing-devops-agent-orchestrator:fix/webapp-lockfile-sync?expand=1 Use the title/description I provided.
Issue: paste the body I provided into aws-samples → Issues → New issue, and link the PR.
Recap of the whole fix
Lockfile out of sync (Dependabot vite‑8 bump) → reverted to vite 5 on the fork; deploy went green (job #7).
No CDK bootstrap in 616795657009 → ran cdk bootstrap (created CDKToolkit).
No Amplify service role → created AmplifyBackendDeploy-devopsagent-orchestrator with AmplifyBackendDeployFullAccess and set it on the app.
Prevention → Web App CI runs npm ci on PRs, now on the fork's main and in the upstream PR branch.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.