Skip to content

deps: fix protobufjs + newly-expanded advisories (#251-259) - #150

Merged
laileni-aws merged 5 commits into
aws:mainfrom
laileni-aws:fix/protobufjs-dos-251
Jul 31, 2026
Merged

deps: fix protobufjs + newly-expanded advisories (#251-259)#150
laileni-aws merged 5 commits into
aws:mainfrom
laileni-aws:fix/protobufjs-dos-251

Conversation

@laileni-aws

@laileni-aws laileni-aws commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Problem

A fresh batch of Dependabot alerts (medium/high) affects packages this repository already pins through overrides. Several advisories expanded after earlier patched versions were selected; most recently, #259 expanded the vulnerable fast-uri range through 3.1.3.

Solution

Bump the existing overrides to versions outside the current advisory ranges and regenerate the root lockfile. Alert #259 is folded into this existing PR because it affects the same fast-uri override and files as #257.

Alert(s) Package Bump Severity
#251 protobufjs 7.6.3 → 7.6.5 medium
#252 brace-expansion (1.x) 1.1.13 → 1.1.16 high
#253 js-yaml (4.x) 4.2.0 → 4.3.0 high
#254 shell-quote 1.8.4 → 1.9.0 high
#255, #256 immutable 4.3.8 → 4.3.9 high
#257, #259 fast-uri 3.1.2 → 3.1.4 high
#258 linkify-it 5.0.1 → 5.0.2 high

Version-scoped overrides (pkg@major) are used where multiple majors coexist (brace-expansion, js-yaml).

Verification

  • Root package-lock.json regeneration is byte-for-byte idempotent.
  • npm ci --ignore-scripts passes; both generated streaming clients install and build successfully.
  • npm ls fast-uri --all reports only 3.1.4 with no dependency problems.
  • npm audit no longer reports fast-uri.
  • npm run compile passes.
  • npm run lint passes.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Bump the protobufjs override 7.6.3 -> 7.6.5 (GHSA-j3f2-48v5-ccww:
DoS via infinite loop in .proto option parsing; vulnerable 7.5.0-7.6.4).
Transitive runtime dependency; single version in the tree; root lockfile
only; verified idempotent.
Bump existing overrides to the versions required by advisories that were
expanded/updated on 2026-07-21, re-flagging our pinned versions:
- brace-expansion (1.x) 1.1.13 -> 1.1.16 (#252)
- js-yaml (4.x) 4.2.0 -> 4.3.0 (#253)
- shell-quote 1.8.4 -> 1.9.0 (#254)
- immutable 4.3.8 -> 4.3.9 (#255, #256)
- fast-uri 3.1.2 -> 3.1.3 (#257)
- linkify-it 5.0.1 -> 5.0.2 (#258)

All verified resolved against the current advisory ranges; root lockfile
only; verified idempotent.
@laileni-aws laileni-aws changed the title deps: fix protobufjs DoS advisory (#251) deps: fix protobufjs + newly-expanded advisories (#251-258) Jul 22, 2026
@laileni-aws
laileni-aws marked this pull request as ready for review July 22, 2026 18:12
@laileni-aws
laileni-aws requested a review from a team as a code owner July 22, 2026 18:12
@laileni-aws laileni-aws changed the title deps: fix protobufjs + newly-expanded advisories (#251-258) deps: fix protobufjs + newly-expanded advisories (#251-259) Jul 30, 2026
@laileni-aws

Copy link
Copy Markdown
Contributor Author

CI is fully green after syncing current main.

PR head a9e73a848 includes upstream main at 0c4d92ae1. Run 30592062672 completed with 16 passing jobs, 0 failures, and only the intentionally disabled lint-duplicate-code job skipped.

Both test macOS (stable) and test macOS (insiders) now pass with the @vscode/test-electron@3.1.0 fix inherited from main. The net PR delta remains scoped to package.json and package-lock.json security updates.

@laileni-aws
laileni-aws merged commit 5d36e75 into aws:main Jul 31, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants