Skip to content

fix(toolkit-lib): cdk validate drops the plugin's customSeverity label #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aws-cdk-automation merged 1 commit into from
Aug 25, 2026
+19 −1
Merged

fix(toolkit-lib): cdk validate drops the plugin's customSeverity label #1894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@aws-cdk/toolkit-lib/lib/api/validate/validate-formatting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function flattenViolations(reports: PluginReportJson[]): FlattenedViolation[] {
const pluginName = report.pluginName;
return report.violations.flatMap((violation) => {
return violation.violatingConstructs.map((construct) => ({
severity: normalizeSeverity(violation.severity),
severity: normalizeSeverity(violation.severity, violation.customSeverity),
description: violation.description,
ruleName: violation.ruleName,
pluginName,
Expand Down
18 changes: 18 additions & 0 deletions packages/@aws-cdk/toolkit-lib/test/api/validate/validate-formatting.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,24 @@ describe('formatValidateResult', () => {
]);
});

test('uses the plugin-supplied customSeverity label for a "custom" severity violation', () => {
const result = makeResult([{
pluginName: 'TestPlugin',
conclusion: 'failure',
violations: [{
ruleName: 'r1',
description: 'blocker issue',
severity: 'custom',
customSeverity: 'BLOCKER',
violatingConstructs: [{ constructPath: 'Stack/A' }],
}],
}]);

const output = formatValidateResult(result);
expect(output).toContain('BLOCKER');
expect(output).not.toContain('INFO');
});

test('formats construct path with logical id', () => {
const result = makeResult([{
pluginName: 'TestPlugin',
Expand Down
Loading