Add opt-in system crypto-policies seeding for SSL_CTX (broad approach) - #3442
Draft
WillChilds-Klein wants to merge 1 commit into
Draft
Add opt-in system crypto-policies seeding for SSL_CTX (broad approach)#3442WillChilds-Klein wants to merge 1 commit into
WillChilds-Klein wants to merge 1 commit into
Conversation
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
WillChilds-Klein
temporarily deployed
to
auto-approve
August 21, 2026 16:27 — with
GitHub Actions
Inactive
Contributor
|
🔒 Security Review — View Report Please review before merging. |
WillChilds-Klein
force-pushed
the
feature/crypto-policies-support
branch
from
September 1, 2026 20:38
41feace to
1c54250
Compare
WillChilds-Klein
force-pushed
the
feature/crypto-policies-support
branch
from
September 1, 2026 20:54
1c54250 to
6a8cad8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3442 +/- ##
==========================================
- Coverage 78.07% 78.07% -0.01%
==========================================
Files 700 700
Lines 124787 124787
Branches 17340 17341 +1
==========================================
- Hits 97432 97427 -5
- Misses 26489 26494 +5
Partials 866 866 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
No existing issue. This is a draft to solicit feedback on approach before investing further.
Description of changes:
AWS-LC deliberately ignores system configuration today. On distributions with the
crypto-policiesframework (notably Amazon Linux 2023 and Fedora, which share it), an operator selects a system-wide policy that is rendered to an OpenSSL back-end file describing the OS TLS posture. This PR lets AWS-LC optionally honor that policy so applications inherit it without code changes.This is the "broad" approach: behind a new off-by-default CMake flag (
-DENABLE_CRYPTO_POLICIES), every context created bySSL_CTX_newis automatically seeded from the system policy after AWS-LC's built-in defaults, and consumers can still override afterward. It applies the policy's cipher, protocol-version, signature-algorithm, and group directives. Seeding is best-effort and never fatal: a missing or malformed file, or an unsupported directive, is ignored and the built-in default is kept.Call-outs:
@SECLEVELtoken is parsed and ignored because AWS-LC has no security levels, so only the cipher list is applied and the level's key-size/hash intent is not enforced.-DFIPS=1; it seeds preferences and does not establish FIPS posture.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.