ci: only report new lint issues on PRs - #77
Merged
Conversation
jahkeup
approved these changes
Aug 18, 2026
jahkeup
left a comment
jahkeup
left a comment
Member
There was a problem hiding this comment.
Looks great. I'll check in with you on some follow up changes to the ci/Makefile to tidy up.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lint currently scans the whole repo, so pre-existing issues on master fail every PR regardless of its content (see #76). This enables the action's built-in baselining (
only-new-issues: true) so PRs fail only on lint issues they introduce, and removes the duplicatemake ci-lintstep which has no baseline support and re-reports the pre-existing issues.ci-lintremains in the Makefile for local use. Existing issues on master can be cleaned up separately; this keeps them from blocking unrelated PR