chore(plugin): Add explicit fine-tuning-source tag to trainer templates#205
Open
Reginald-King wants to merge 1 commit into
Open
chore(plugin): Add explicit fine-tuning-source tag to trainer templates#205Reginald-King wants to merge 1 commit into
Reginald-King wants to merge 1 commit into
Conversation
Reginald-King
requested review from
a team,
krokoko,
scottschreckengaust and
theagenticguy
June 26, 2026 18:17
Reginald-King
force-pushed
the
add-fine-tuning-source-tag
branch
from
June 26, 2026 18:22
c4debcb to
556d16d
Compare
…plates
Add tags=[{"Key": "aws-sagemaker:model-customization-client-origin", "Value": "sherpa-plugin"}]
to all fine-tuning code templates (SFT, DPO, RLVR, RLAIF builtin,
RLAIF custom prompt) so training jobs created via this plugin are
tagged with the sherpa-plugin source identifier.
Reginald-King
force-pushed
the
add-fine-tuning-source-tag
branch
from
June 29, 2026 10:00
556d16d to
786e544
Compare
krokoko
changed the title
|
Review feedback: The tag value |
singh96aman
requested changes
Jul 7, 2026
singh96aman
left a comment
singh96aman
left a comment
There was a problem hiding this comment.
Per the PR description shouldn't the tag be
{"Key": "aws:sagemaker:fine-tuning-source", "Value": "StudioUI"}
|
This pull request is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the tag
aws:sagemaker:fine-tuning-source: StudioUIto all fine-tuning trainer constructors in the code templates.Changes
Added
tags=[{"Key": "aws:sagemaker:fine-tuning-source", "Value": "StudioUI"}]to:sft.py(SFTTrainer)dpo.py(DPOTrainer)rlvr.py(RLVRTrainer)rlaif_builtin.py(RLAIFTrainer)rlaif_custom_prompt.py(RLAIFTrainer)Motivation
Training jobs launched via these templates should be explicitly tagged with the StudioUI source identifier for tracking and attribution purposes.