test: canonicalize S3 inbound adapter temp directory - #1657
Open
codingkiddo wants to merge 1 commit into
Open
Conversation
codingkiddo
requested review from
MatejNedic,
maciejwalkowiak and
tomazfernandes
as code owners
July 23, 2026 05:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Canonicalize the temporary directory used by
S3InboundChannelAdapterTestsbefore creating the local download directory.The test now resolves
TEMPORARY_FOLDERwithtoRealPath(), ensuring that the path used when storing S3 remote-file metadata matches the canonical path later used by Spring Integration when reading the downloaded file.💡 Motivation and Context
On macOS, JUnit may create temporary directories under
/var/folders, while file canonicalization resolves the same location under/private/var/folders.The S3 inbound synchronizer stores remote-file metadata using the original absolute path. Spring Integration later looks up that metadata using the canonical file path. Because the two paths differ, the metadata lookup fails and the following expected headers are missing:
file_remoteDirectoryfile_remoteHostPortfile_remoteFileCanonicalizing the temporary directory before configuring the inbound adapter keeps the metadata storage and lookup paths consistent.
💚 How did you test it?
Ran the focused failing test:
./mvnw \ -pl spring-cloud-aws-s3 \ -Dtest=S3InboundChannelAdapterTests \ testRan the complete S3 module tests:
./mvnw -pl spring-cloud-aws-s3 testResumed the remaining Maven reactor build:
The remaining reactor build completed successfully.
📝 Checklist
🔮 Next steps
None.