Fix resource pack and status bar assets - #3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 208efbc853
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| target.setKiller(source); | ||
| target.setLastDamage(finalDamage); | ||
| target.setLastDamageCause(damageEvent); | ||
| target.setHealth(Math.max(0.0, target.getHealth() - finalDamage)); |
There was a problem hiding this comment.
When Breeze hits a target that has absorption hearts (for example from a golden apple), this new direct setHealth subtraction skips the absorption pool entirely. The previous target.damage(...) path would consume absorption first, and the new Ember true-damage helper in this commit does that explicitly, so Breeze can now remove real health or kill players while their absorption hearts remain.
Useful? React with 👍 / 👎.
| meta.setTrim(null); | ||
| item.setItemMeta(meta); | ||
| } | ||
| continue; |
There was a problem hiding this comment.
For players who already have the old Heart Helmet PDC item, this migration branch only removes the trim and then exits, so those existing helmets never receive the new arcanesmp:the_crown item/equippable model that HeartHelmet.create() now sets. After updating the plugin/resource pack, existing owners will keep a plain netherite helmet instead of seeing The Crown unless this path also writes the new model metadata.
Useful? React with 👍 / 👎.
1 participant
No description provided.