Skip to content

Preserve confirmed empty AMS spool weights - #11697

Open
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/ams-spool-sync-edge-cases
Open

Preserve confirmed empty AMS spool weights#11697
BenJule wants to merge 1 commit into
bambulab:masterfrom
BenJule:fix/ams-spool-sync-edge-cases

Conversation

@BenJule

@BenJule BenJule commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Preserve a confirmed empty AMS spool as 0 g and 0% throughout device parsing, the web filament manager, and cloud serialization.

Root cause

A remaining weight of zero was treated as equivalent to an unknown value. Later fallbacks reconstructed the full initial weight and could persist an empty spool as full.

Changes

  • preserve firmware-reported and calculated zero remaining weight
  • distinguish unknown remaining weight from confirmed 0 g
  • keep single-slot and batch payloads at 0 g and 0%
  • serialize confirmed empty spools with netWeight: 0
  • retain existing fallback behavior for genuinely unknown weight
  • update regression and source-contract coverage

Validation

  • buildSpoolFromTray.test.ts when local Node dependencies are available
  • TypeScript project check when local Node dependencies are available
  • git diff --check
  • one GPG-signed commit

Full native validation remains delegated to Jenkins.

No local full build was performed.

@BenJule
BenJule force-pushed the fix/ams-spool-sync-edge-cases branch from 99c16c9 to 894c0bf Compare July 25, 2026 10:44
@BenJule BenJule changed the title Fix AMS spool sync edge cases Preserve confirmed empty AMS spool weights Jul 25, 2026
@BenJule
BenJule force-pushed the fix/ams-spool-sync-edge-cases branch from 894c0bf to 198bda1 Compare July 25, 2026 14:16
@BenJule
BenJule marked this pull request as ready for review July 25, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant