Fix failing npm audit in the TypeScript SDK - #840
Conversation
The fast-uri override lower bound (>=3.1.5) still permitted 3.1.5, which GHSA-5jgf-p345-68v8 and related advisories flag as high severity (host confusion / SSRF). fast-uri reaches the tree transitively through the openapi-typescript devDependency. Raise the bound to >=3.1.7 so the override resolves to the patched 3.x release, clearing npm audit --audit-level=high.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The override and lockfile consistently resolve the reported vulnerability without runtime code changes.
Pull request overview
Updates the TypeScript SDK’s transitive fast-uri dependency to a secure 3.x release.
Changes:
- Raises the override minimum to
3.1.7. - Regenerates the lockfile, hoisting and deduplicating the dependency.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
typescript/package.json |
Requires the patched dependency version. |
typescript/package-lock.json |
Locks fast-uri at 3.1.7. |
Review details
Files not reviewed (1)
- typescript/package-lock.json: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
No issues found across 2 files
You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Problem
The npm Audit (TypeScript SDK) CI step (
npm audit --audit-level=highintypescript/) fails onmain:fast-uri, high severity, fixed in3.1.6.openapi-typescript(devDependency) →@redocly/openapi-core→@redocly/ajv→fast-uri. No runtime/published exposure.overridesentry already pinnedfast-urifor security, but its lower bound (>=3.1.5 <4) still permitted the now-vulnerable3.1.5.Fix
Raise the existing override bound to
>=3.1.7 <4and regeneratepackage-lock.json. This stays within the3.xmajor (non-breaking), matches how the repo already handles audit exceptions (theoverridesblock), and touches only the TypeScript package + its lockfile — no other-language SDK output.Verification (local, Node 24 as in CI)
npm audit --audit-level=high→ found 0 vulnerabilitiesnpm run build→ passnpm run typecheck→ passnpm test→ 1698 passed (87 files)fast-uri(bumped 3.1.5 → 3.1.7, hoisted/deduped).Summary by cubic
Fixes the failing
npm auditstep in the TypeScript SDK by raising thefast-urioverride bound from>=3.1.5 <4to>=3.1.7 <4and regenerating the lockfile, so npm resolves the patched 3.1.7 instead of the vulnerable 3.1.5.Bug Fixes
fast-urireaches the tree transitively via theopenapi-typescriptdevDependency and never ships in runtime output.Written for commit fc4b3af. Summary will update on new commits.