Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync API docs from bc3: Basecamp-served authorization document #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Sync API docs from bc3: Basecamp-served authorization document #435
Changes from all commits
b462c21File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When readers use the endpoint list at the top of this section for discovery or anchor navigation, the newly added endpoint is missing, so they cannot see or jump to
#get-authorization-from-basecampfrom that list. Add a matching bullet alongside the existing authorization link, as required by the section-file structure.AGENTS.md reference: AGENTS.md:L38-L42
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For users choosing an authentication method, this newly documented support for personal access tokens directly conflicts with both this guide's opening statement that all requests use OAuth 2 and README.md's authentication section saying OAuth 2 is mandatory. Update the overview and main guide to describe when personal access tokens are supported; otherwise readers receive mutually exclusive instructions about a token type this endpoint explicitly accepts.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a client needs the authenticated user's name or email omitted from this document, the linked
Get personendpoint requires a Basecamp person ID, while this paragraph explicitly says the returned identity ID is not suitable for identifying that person. Following the link therefore leaves the client without a usable ID and may lead it to request the wrong profile; point readers toGET /my/profile.json(Get my personal info), which resolves the current user without an ID.Useful? React with 👍 / 👎.