Skip to content

Document the Lineup API (read model + project schedule editing) - #442

Closed
jeremy wants to merge 1 commit into
masterfrom
lineup-api
Closed

Document the Lineup API (read model + project schedule editing)#442
jeremy wants to merge 1 commit into
masterfrom
lineup-api

Conversation

@jeremy

@jeremy jeremy commented Sep 2, 2026

Copy link
Copy Markdown
Member

Adds sections/lineup.md documenting the new Lineup JSON API and registers it in the README index (before "Lineup Markers").

Covers:

  • GET /lineup.json — the account-wide read model: timeframe, scheduled projects with their ranges and status, and markers. Documents the optional timeframe=START..END param and the default window.
  • GET /lineup/projects/:project_id/schedule.json — a project's start/end dates.
  • PUT /lineup/projects/:project_id/schedule.json — editing those dates, with the 422 invalid-dates response and the topic-only / no-clients / edit-permission rules.

Pairs with the bc3 implementation PR basecamp/bc3#13128. Cards: Agent Accessibility "BC API Gaps" — 9671195038 and 9671195121.

Copilot AI balanced review requested due to automatic review settings September 2, 2026 18:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T19:02:43.669754Z 5c94eae PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The documentation must originate in bc3 and be regenerated through the repository’s sync process.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Documents Lineup retrieval and project schedule management.

Changes:

  • Adds Lineup endpoint documentation and examples.
  • Adds Lineup to the endpoint index.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File summaries
File Description
sections/lineup.md Documents Lineup and project schedule endpoints.
README.md Adds Lineup to the endpoint index.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md
- [Hill charts](sections/hill_charts.md#hill-charts)
- [Inbox replies](sections/inbox_replies.md#inbox-replies)
- [Inboxes](sections/inboxes.md#inboxes)
- [Lineup](sections/lineup.md#lineup)
Comment thread sections/lineup.md
@@ -0,0 +1,129 @@
Lineup

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c94eae025

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sections/lineup.md
@@ -0,0 +1,129 @@
Lineup

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate the docs through the bc3 sync

This commit adds sections/lineup.md and edits README.md, but its description lacks the required sync footer and instead says it merely pairs with a bc3 implementation PR. That identifies this as an off-target edit that will diverge from bc3/doc/api and be overwritten by the next sync; land the documentation in bc3 and run script/api/sync_to_bc3_api before merging.

AGENTS.md reference: AGENTS.md:L22-L31

Useful? React with 👍 / 👎.

@jeremy

jeremy commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Closing — the API docs belong in bc3's source-of-truth doc/api/ (this repo is the sync-target mirror, regenerated by script/api/sync_to_bc3_api, so direct edits here get overwritten). The Lineup docs now live in basecamp/bc3#13128 as doc/api/sections/lineup.md + a DocUpdater#update_lineup, and will sync here on the next run.

@jeremy jeremy closed this Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants