fix(served): idempotency key on reservation writes (0.3.2) - #45
Merged
Conversation
…3.2) The adapter declares every work.reservation.* operation idempotency=required, but reservation_operation() never sent a key, so the authority rejected each reserve/touch/release with idempotency-key-required — after the authority check, so a correctly granted identity looked like a missing grant. Keys are unique per call by default (touch must advance activity every time), an explicit key passes through for retries, and work.read.reservation stays unkeyed because reads reject one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hwq1vFjhdXjLPP97cZVkJa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while probing the new work:write grant: the authority rejected
sprintctl reservation reservewithidempotency-key-requiredbecause the client never sent one forwork.reservation.*(adapter declares themrequired). Unique key per call by default, explicit key passthrough for retries, reads stay unkeyed. Regression test added; suite 1275 passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Hwq1vFjhdXjLPP97cZVkJa