Fix duplicate analyzers - #550
Open
soda0289 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467 by removing duplicate analyzers by matching by name. An analyzer can get added twice when a nuget package and framework sdk both include the same analyzer. This happened with
Microsoft.Extensions.Configuration.Binder.SourceGeneration.dllsince bothMicrosoft.Extensions.Configuration.Binderand dotnet ASP.Net web framework include it.MSBuild resolves duplicate analyzers in ResolvePackageFileConflicts by using file name ( ci => ci.FileName ), then breaks ties by AssemblyVersion (managed metadata) and FileVersion (Win32 resource).
This is the same kind of fix as PR #512 but includes reproduction test case and an e2e regression test.