fix: declare repo rules reproducible so they can use the repo contents cache - #901
Open
alexander-scott wants to merge 2 commits into
Open
fix: declare repo rules reproducible so they can use the repo contents cache#901alexander-scott wants to merge 2 commits into
alexander-scott wants to merge 2 commits into
Conversation
Repo rules whose outputs are fully determined by their attributes must return `repository_ctx.repo_metadata(reproducible = True)`, otherwise Bazel refuses to store them in the repo contents cache - local (`--repo_contents_cache`) or remote (`--experimental_remote_repo_contents_cache`). None of the repo rules in rules_oci did this, so every one of them was re-fetched from scratch in each fresh output base, and none could be shared remotely. All the toolchain rules (crane, regctl, cosign, toolchains_repo) are unconditionally reproducible: they either download an artifact pinned by an integrity hash, or template files purely from their attributes. `oci_pull` and `oci_alias` are reproducible only when pulling by digest. With a tag the registry may move it to different content between fetches, so they stay uncached in that case.
alexander-scott
changed the title
alexander-scott
marked this pull request as ready for review
July 30, 2026 06:54
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a215a05996
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Only mark sha256 digests as reproducible
Author
|
@thesayyn Hey if you have a minute, could you give some feedback to this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo rules whose outputs are fully determined by their attributes must return
repository_ctx.repo_metadata(reproducible = True), otherwise Bazel refuses to store them in the repo contents cache - local (--repo_contents_cache) or remote (--experimental_remote_repo_contents_cache).None of the repo rules in rules_oci did this, so every one of them was re-fetched from scratch in each fresh output base, and none could be shared remotely.
All the toolchain rules (crane, regctl, cosign, toolchains_repo) are unconditionally reproducible: they either download an artifact pinned by an integrity hash, or template files purely from their attributes.
oci_pullandoci_aliasare reproducible only when pulling by digest. With a tag the registry may move it to different content between fetches, so they stay uncached in that case.