[9.3.0] Support pass-through Args for JavaBuilder in java_common.create_compilation_action - #30981
Merged
Merged
Conversation
fmeum
marked this pull request as ready for review
September 2, 2026 16:36
github-actions
Bot
added
team-Rules-Java
fmeum
force-pushed
the
cp-9.3.0-30808
branch
from
September 2, 2026 17:27
adab3c2 to
a605120
Compare
iancha1992
enabled auto-merge
September 2, 2026 19:26
Member
|
We don't need 61218bb, it doesn't do anything. We can just ignore the |
…compilation_action` (bazelbuild#30808) This allows faster iteration on the `rules_java` <> `JavaBuilder` contract without having to wait for Bazel changes/releases. In the immediate future, this will be used for the unused-deps checking. Longer term this should also help in migrating off the native compilation code. Note: the added integration shell test is currently a no-op on CI (since we need the corresponding rules_java changes) but does allow for local testing with an overridden `@rules_java`. Closes bazelbuild#30808. PiperOrigin-RevId: 971826913 Change-Id: I8047e057716475a7a4d8bff48b8c7bfe6d79ba1c (cherry picked from commit 0e6f09d)
auto-merge was automatically disabled
September 3, 2026 09:55
Head branch was pushed to by a user without write access
fmeum
force-pushed
the
cp-9.3.0-30808
branch
from
September 3, 2026 09:55
a605120 to
4837dde
Compare
Collaborator
Author
|
@hvadehra Dropped! |
hvadehra
approved these changes
Sep 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 3, 2026
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows faster iteration on the
rules_java<>JavaBuildercontract without having to wait for Bazel changes/releases. In the immediate future, this will be used for the unused-deps checking. Longer term this should also help in migrating off the native compilation code.Note: the added integration shell test is currently a no-op on CI (since we need the corresponding rules_java changes) but does allow for local testing with an overridden
@rules_java.Closes #30808.
PiperOrigin-RevId: 971826913
Change-Id: I8047e057716475a7a4d8bff48b8c7bfe6d79ba1c
(cherry picked from commit 0e6f09d)
9.3.0 adaptation:
java_common.bzlhas no_ALLOWLISTconstant on this branch, sobazel_internal/test_rulesis added to the allowlist passed inline tocheck_private_api.JavaCompileActionBuilderTestneeded atestutil:TestConstantsdep for the new test. Thebazel_java_test.shcases are left out: they exercise--experimental_check_unused_deps, which is a JavaBuilder option added by #30807 and not present on this branch, and they are a no-op on CI anyway.JavaCompileActionBuilderTestand all four shards of//src/test/shell/bazel:bazel_java_test_jdk17_toolchain_headpass locally.Closes #30968