Map all generated input roots into legacy doctest runfiles - #4271
Merged
UebelAndre merged 1 commit intoSep 28, 2026
Merged
UebelAndre merged 1 commit into
UebelAndre merged 1 commit into
Conversation
This was referenced Sep 24, 2026
jrandolf
force-pushed
the
codex/upstream-doctest-generated-input-roots
branch
from
September 24, 2026 18:14
c0391f4 to
5907e14
Compare
jrandolf
force-pushed
the
codex/upstream-doctest-generated-input-roots
branch
from
September 27, 2026 21:33
5907e14 to
f6c489d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy doctests run from a runfiles directory, but the launcher only strips output roots found through crate and C++ library providers. A generated rustc environment file built in an execution configuration retains a
bazel-out/...path and fails before rustdoc starts.Collect the nonempty roots of every declared action input instead. This also covers generated compiler/linker tools and keeps source paths intact. The new regression executes a doctest using an environment file forwarded through an execution transition; it fails with a missing-file error on main and passes with this change.
Validation on macOS with Bazel 9.2.0: 17 owning tests pass on this standalone branch. This extends the C++ runtime-root handling from #4220. Windows execution was not tested locally.
Closes #4288.