Conversation
This was referenced Sep 24, 2026
jrandolf
force-pushed
the
codex/upstream-compiled-doctest-runfiles
branch
2 times, most recently
from
September 24, 2026 18:14
f31a022 to
84c8c39
Compare
jrandolf
force-pushed
the
codex/upstream-compiled-doctest-runfiles
branch
from
September 27, 2026 21:33
84c8c39 to
3a9e2d3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiled doctests currently inherit their compilation inputs as runfiles. This omits declared crate/dependency runtime data while sending the compiler SDK to the test machine.
Build the runtime files from the crate, explicit dependencies, runner, and compile_data. Preserve native shared libraries from CcInfo, including their resolved symlink targets. The compilation action retains all its original inputs.
A real persisted doctest reads crate, transitive, and extra-dependency data and calls a shared C library. An analysis regression checks the compiler SDK is absent from runfiles and remains a compilation input. Both regressions fail on main and pass here; 53 nightly tests pass on macOS, and the stable legacy smoke test also passes. Both new tests are enabled only with nightly compiled doctests and are disabled on Windows, where the existing runner lacks its executable suffix.
The shared-library fixture uses a runfiles-relative install name/SONAME to isolate file propagation from the existing persisted-doctest rpath behavior. This does not add a
dataattribute or change the public rule API. Linux and Windows execution were not tested locally.Upstream CI passed after the regression tests were changed to inherit the selected channel. Stable-only, stable-with-aspects, and nightly-with-aspects configurations were also checked locally.
Closes #4289.