Conversation
This was referenced Sep 24, 2026
jrandolf
force-pushed
the
codex/upstream-cargo-lints
branch
2 times, most recently
from
September 27, 2026 21:33
35c20dc to
24715f6
Compare
jrandolf
force-pushed
the
codex/upstream-cargo-lints
branch
from
September 28, 2026 19:15
24715f6 to
18b85ec
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo lint extraction only needs the declared package and optional workspace manifests. Fully resolving the Cargo package also reads workspace members and resources that are absent from a sandboxed Bazel action. Read the manifests directly and preserve workspace lint inheritance.
The regression covers an undeclared workspace member and resource path. The Python test lives in the test package, so downstream users do not need rules_python. A nested downstream consumer check is documented as a manual test.
Validation: both owning tests pass locally on macOS arm64 with Bazel 9.2.0 at 18b85ec:
//cargo/private/cargo_toml_info:unit_testand//cargo/tests/cargo_toml_info:declared_manifests_test.Closes #4290.