Skip to content

rustdoc: preserve the test invocation environment - #4277

Merged
UebelAndre merged 1 commit into
bazelbuild:mainfrom
jrandolf:codex/upstream-doctest-environment
Sep 28, 2026
Merged

UebelAndre merged 1 commit into
bazelbuild:mainfrom
jrandolf:codex/upstream-doctest-environment

Conversation

@jrandolf

@jrandolf jrandolf commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Preserve Bazel's test and runfiles variables when the legacy doctest launcher starts rustdoc. Invocation values override stale action-time values, and temporary-directory variables follow TEST_TMPDIR.

The doctest-writer tests and existing Rustdoc analysis suite pass on macOS. Regressions cover Unix execution, Windows script generation, and a Windows execution test for CI. Related to #4209; this does not introduce env or env_inherit attributes.

Closes #4292.

@UebelAndre UebelAndre left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre
UebelAndre added this pull request to the merge queue Sep 28, 2026
Merged via the queue into bazelbuild:main with commit bb276bd Sep 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legacy doctest launchers discard Bazel test and runfiles environment variables

2 participants