Skip to content

Fix rust_analyzer_proc_macro_srv on Windows by setting PATH in launcher #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UebelAndre merged 1 commit into from
Sep 27, 2026
+15 −1
Merged

Fix rust_analyzer_proc_macro_srv on Windows by setting PATH in launcher #4286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tools/rust_analyzer/bin/launcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,21 @@ fn exec_replace(target: &Path) -> ! {

#[cfg(not(unix))]
fn exec_replace(target: &Path) -> ! {
let status = process::Command::new(target)
let mut cmd = process::Command::new(target);

// On Windows, ensure the respective bin/ folder is on PATH.
// This is necessary for rust_analyzer_proc_macro_srv, as it's in libexec/
// and otherwise would be missing .dlls
#[cfg(windows)]
if let Some(sys_root) = target.parent().and_then(Path::parent) {
let bin_dir = sys_root.join("bin");
let mut path = std::env::var_os("PATH").unwrap_or("".into());
path.push(";");
path.push(bin_dir);
cmd.env("PATH", path);
}

let status = cmd
.args(env::args_os().skip(1))
.status()
.unwrap_or_else(|e| die(format!("spawn {}: {e}", target.display())));
Expand Down
Loading