Silent google sign in login - #4793
Conversation
|
Lightbeam link |
|
Due to importance of this and what it touches, i had Codex/Sol-high go through it. Please take these with a grain of salt. Findings
What aligns correctlyLegacy Google The unique receiver names, asynchronous string callback, One strategic caveat: this entire Google Sign-In API is deprecated. Credential Manager is the supported replacement, but its automatic flow may briefly display a bottom sheet, so it does not preserve the strict zero-UI requirement. Treat this PR as a compatibility bridge and create a migration follow-up. Google migration guide. |
|
Lightbeam link |
|
We can disregard the Jenkins issue: for this plugin, Jenkins was never a test harness for continuous integration; rather, it was a glorified build box. We should translate that build to GitHub Actions so that rebuilding the AAR does not depend on any individual developer's laptop, but the GHA we create really just needs to have the right Java version and be capable of running a Gradle build. For all practical purposes, game developers will just use the AAR file we ship with the SDK, right, @Leinnan ? That is, nobody using the Beamable Unity SDK should need to rebuild the plugin on their own (but they may do so if they wish, by following instructions in the README), right? |
Correct. The PR s ready for review, I was able to build it and test the login and silent login. |
|
Lightbeam link |
|
@Leinnan Did another codex pass, all previous stuff have been addressed which gr8. A couple according to it remain. Again take this with a grain of salt: #Remaining findings
The newly committed When Unity minification uses this file, the release build can fail while parsing the configuration. This path now applies to ordinary Google Sign-In projects, not only GPGS. Android keep-rule syntax, Unity ProGuard behavior. Fix the generator with something equivalent to: Also correct or remove the committed
This matters because
Unity 2021.3.29 uses AGP 4.0.1, while Android documents that the namespace DSL begins with AGP 7.3. Unity 2021.3 compatibility table, Android AGP namespace requirement. |
|
Lightbeam link |
|
Lightbeam link |
allister-beamable
left a comment
There was a problem hiding this comment.
I like the improvements on the error case handling.
Needs some developer-facing docs, but that might be as simple as adding a section to the Google Sign-In page saying "use .signInSilent to perform a silent, automatic login", right?
Good to merge to main from my perspective, though we will want to do as much thorough on-device testing as we can.
…IgnInLogin # Conflicts: # client/Packages/com.beamable/CHANGELOG.md
|
Lightbeam link |
|
Lightbeam link |
|
Lightbeam link |
Ticket
Implements #4750
Brief Description
Refactor the Google SignIn plugin and add the silent login functionality.