Skip to content

Leave a shipped milestone open when it still holds open items #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allister-beamable wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Leave a shipped milestone open when it still holds open items #4813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions .github/workflows/release-unity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,23 +396,40 @@ jobs:
}
}'

# Close the matching "Unity X.Y.Z" milestone once a production release ships.
# Warns (does not fail) when no open milestone matches, so it never blocks a release. ~Claude
# Close the matching "Unity X.Y.Z" milestone once a production release ships,
# but only when nothing is still open in it. A milestone holding open issues has
# not shipped everything it claims, and closing it drops it off the default
# milestones view -- the issues stay open and stay attached, but they stop being
# somewhere anyone looks. So leave it open and name the stragglers instead.
# Warns, never fails: this step cannot block or redden a release.
- name: Close shipped milestone
if: ${{ inputs.dryRun == false && inputs.releaseType == 'production' }}
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
title="Unity ${{ inputs.major }}.${{ inputs.minor }}.${{ inputs.patch }}"
num=$(gh api "repos/${{ github.repository }}/milestones?state=open&per_page=100" \
--jq ".[] | select(.title==\"$title\") | .number")
if [ -n "$num" ]; then
gh api -X PATCH "repos/${{ github.repository }}/milestones/$num" -f state=closed
echo "Closed milestone $title (#$num)"
else
milestone=$(gh api "repos/${{ github.repository }}/milestones?state=open&per_page=100" \
--jq ".[] | select(.title==\"$title\")" || true)

if [ -z "$milestone" ]; then
echo "::warning::No open milestone titled '$title' to close"
exit 0
fi

num=$(printf '%s' "$milestone" | jq -r '.number')
open_count=$(printf '%s' "$milestone" | jq -r '.open_issues')

if [ "$open_count" -gt 0 ]; then
echo "::warning::Milestone '$title' still has $open_count open item(s), so it was left OPEN. Move them to the next milestone, then close '$title' by hand."
gh issue list --repo "${{ github.repository }}" --milestone "$title" \
--state open --limit 100 --json number,title \
--jq '.[] | "::warning::still open in milestone: #\(.number) \(.title)"' || true
exit 0
fi

gh api -X PATCH "repos/${{ github.repository }}/milestones/$num" -f state=closed
echo "Closed milestone $title (#$num)"

lightbeam:
needs: package
uses: ./.github/workflows/lightBeamRelease.yml
Expand Down
Loading