Skip to content

Ship one example configuration #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beetlebugorg merged 2 commits into from
Sep 1, 2026
Merged

Ship one example configuration #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e178d6
Remove the second example configuration
beetlebugorg Sep 1, 2026
544723e
Comment out the allowlist in the example
beetlebugorg Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions conf/mod_dims.conf.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,10 @@ DimsAllowPrivateAddresses off

# The hosts an image may come from. A leading *. matches subdomains only, not
# the apex. This list applies to /dims3/. A signed request skips it unless you
# enable DimsAllowlistSigned below.
DimsAddWhitelist images.example.com
DimsAddWhitelist *.cdn.example.com
# enable DimsAllowlistSigned below. Name a host before /dims3/ can fetch a
# source.
# DimsAddWhitelist images.example.com
# DimsAddWhitelist *.cdn.example.com

# Apply the host allowlist to a signed request and to a redirect. A signed
# request skips the allowlist by default. Enable this once the allowlist covers
Expand Down
33 changes: 0 additions & 33 deletions examples/dims.conf
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions test/cmake/CheckLoadModule.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ set(EXPECTED "modules/libmod_dims.so")
set(CONFIGS
"${DIMS_SOURCE_DIR}/conf/mod_dims.conf.example"
"${DIMS_SOURCE_DIR}/test/conf/dims-test.conf"
"${DIMS_SOURCE_DIR}/docker/dims.conf"
"${DIMS_SOURCE_DIR}/examples/dims.conf")
"${DIMS_SOURCE_DIR}/docker/dims.conf")

foreach(config IN LISTS CONFIGS)
if(NOT EXISTS "${config}")
Expand Down
Loading