feat(spa): full-size album art lightbox on album detail page (#200) - #257
Merged
Conversation
…200) Clicking the cover on ReleaseGroupPage opens a full-viewport lightbox (full-size art via artUrl without a size param). Dismiss by clicking anywhere off the image or pressing Escape; clicking the image itself does not dismiss. Cover is now a keyboard-accessible button. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SwwPcrohddTUN7kmQVedQC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200.
Clicking the cover art on the album detail page (
ReleaseGroupPage) now opens a full-size lightbox — a fixed full-viewport overlay with a dimmed backdrop and the image centered, constrained to the viewport.Behavior
<button>(aria-label) — only rendered when the album has cover art.artUrlwithout asizeparam).role="dialog" aria-modal="true".Implementation
frontend/src/components/Lightbox.tsx+Lightbox.test.tsx(4 tests).ReleaseGroupPage.tsx:lightboxOpenstate + button wrapper; 3 new page-level tests.Verification
pnpm verifygreen: hub + frontend suites (133 frontend tests incl. 7 new), typecheck, boundary lint.pnpm lintzero errors/warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01SwwPcrohddTUN7kmQVedQC