Skip to content

docs: fold session-memory lessons into committed docs - #262

Merged
benders merged 1 commit into
mainfrom
chore/docs-memory-extraction
Jul 16, 2026
Merged

docs: fold session-memory lessons into committed docs#262
benders merged 1 commit into
mainfrom
chore/docs-memory-extraction

Conversation

@benders

@benders benders commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Closes #261.

Audited all persistent agent memories (ICM topics + auto-memory) for lessons that existed only in session memory, and folded the durable ones into committed docs. Most memory content was already covered (art-cache #145 docs, login-loop rule in authentication.md, merge-worker dual-path row) or is ephemeral/historical — this PR adds only the gaps:

File Addition
README.md Node 22 requirement for local dev — newer majors lack a better-sqlite3 prebuild (NODE_MODULE_VERSION mismatch)
docs/pitfalls.md getAlbumList2 inline-SQL is a deliberate exception to the #130 hoisting rule
docs/pitfalls.md merge-worker must stay dependency-light (loads standalone under tsx and as compiled JS)
docs/pitfalls.md Never proxy the Navidrome native API to peers — unversioned full admin surface (from the #252 design decision)
docs/pitfalls.md Process: concurrent agent sessions sharing one working tree → use git worktree; live hub is not a test bed
docs/frontend-testing.md Duplicate img alt-text collision in RTL queries — scope with within(dialog)
CLAUDE.md Write-tool control-character gotcha (Claude-Code-specific per that file's own rule; hit twice, incl. once while writing this very line)

Docs-only change — no runtime surface.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SwwPcrohddTUN7kmQVedQC

Extracted from persistent agent memory (ICM + auto-memory) so the
committed docs are self-sufficient:

- README: Node 22 requirement for local dev (better-sqlite3 prebuilds)
- pitfalls: getAlbumList2 inline-SQL exception to #130 hoisting rule
- pitfalls: merge-worker must stay dependency-light
- pitfalls: never proxy the Navidrome native API to peers
- pitfalls (Process): concurrent agent sessions need git worktrees;
  live hub is not a test bed (no DB resets, verify uptime + logs)
- frontend-testing: duplicate img alt-text collision, scope with
  within(dialog)
- CLAUDE.md: Write-tool control-character gotcha (Claude Code only)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SwwPcrohddTUN7kmQVedQC
@benders
benders marked this pull request as ready for review July 16, 2026 05:38
@benders
benders merged commit cd6d0cd into main Jul 16, 2026
2 checks passed
@benders
benders deleted the chore/docs-memory-extraction branch July 16, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: fold session-memory lessons into committed docs (pitfalls, README, frontend-testing)

2 participants