fix: restore CI hygiene on main - #2
Merged
Merged
Conversation
- Add root pnpm-lock.yaml symlink so pnpm/setup cache resolves (lockfile lives under frontend/; default cache path is repo-root) - Remove switchbay-sketch stub and code-workspace (belong on exp/vscode-plugin) - Economy workers prefer non-chief cheap providers (gemini/mlx over anthropic haiku) - Harden Pi harness killpg + path assertions for Windows easy wins Signed-off-by: benjsmith <benjamincharlessmith@gmail.com>
benjsmith
force-pushed
the
fix/ci-hygiene
branch
from
September 12, 2026 23:51
6e3f60a to
c57797c
Compare
Compare toolscope path assertions with Path.as_posix() (production rules already use forward slashes) and emit skill-mirrors Read rules the same way. Inherit PATH in version_sync subprocess env so Windows winsock/_overlapped keep working. Skip the Pi stdin probe on win32 where select.select is sockets-only. Signed-off-by: benjsmith <benjamincharlessmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores green CI on
mainafter the vault-tab merge (#1).pnpm/setup@v2defaults tocache-dependency-path: pnpm-lock.yamlat the repo root, but the lockfile lives atfrontend/pnpm-lock.yaml, which made cache restore fail with "Some specified paths were not resolved". Added a rootpnpm-lock.yaml→frontend/pnpm-lock.yamlsymlink so the default path resolves (install still runs viapnpm --dir frontend). Preferred YAML fix (cache-dependency-path: frontend/pnpm-lock.yaml) needs a token withworkflowscope and can follow up.extensions/switchbay-sketch/(stub leftover) andswitchbay.code-workspace. Sketch/workspace experiment files belong onexp/vscode-plugin, not main. Keptextensions/switchbay-vs(guard does not forbid it). Added gitignore entries so they stay off main.pick_worker_modelat preference ≤ 0.25 breaks strength ties by preferring a provider other than the chief’s. Economy non-review workers pick gemini/mlx flash-class instead of anthropic haiku when both score equally.harness_pi._killpgguards missingos.killpg; harness PATH/PYTHONPATH tests useos.pathsep/Pathinstead of POSIX-only/and:.Test plan
PYTHONPATH=src uv run --with pytest pytest tests/unit/test_kernel_hire.py tests/unit/test_kernel_packages.py -qtests/uniton Linux (all green)Still red on Windows (not blocking)
test_ce_toolscopesymlink path formstest_version_sync::test_reported_version_is_the_running_one(WinError 10106 / overlapped I/O under stripped PATH)Sketch companion belongs on
exp/vscode-plugin.