fix: Help versions footer + version sync (0.12.16) - #5
Merged
Merged
Conversation
Reserve space for Help → versions rows (flex-shrink, min-height, wrap/scroll) so the footer is not crushed to a "versions…" stub. Sync switchbay.__version__ to 0.12.16. Document make refresh BUILD=1 for stale PWA bundles still showing bottom-rail Web off. Signed-off-by: benjsmith <benjamincharlessmith@gmail.com>
Signed-off-by: benjsmith <benjamincharlessmith@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex-shrink: 0, min-height, wrap/scroll so multiple version rows are not crushed to a one-lineversions…stub by.sy-settings-body.switchbay.__version__to 0.12.16 (pyproject/package.json already bumped; version_sync was broken on main).make refresh BUILD=1for stale PWA bundles still showing bottom-railWeb off/ missingedges:auto.Diagnosis vs Ben's screenshot: no duplicate bottom Web control remains in source (
WebPolicyToggleonly in.sy-rail-head). Bottomweb off+ missing edges pill ⇒ stale frontend bundle. Help versions cramped ⇒ remaining CSS bug (this PR).Atlas sticky selection already on main via #4 — not blocked.
Test plan
pytest tests/unit/test_version_sync.pygreengit pull && make refresh BUILD=1, hard-reload PWA — Web toggle at rail head, edges pill present